Add an option to generate API calls using a DbxRequest wrapper#564
Open
jonamireh wants to merge 6 commits into
Open
Add an option to generate API calls using a DbxRequest wrapper#564jonamireh wants to merge 6 commits into
jonamireh wants to merge 6 commits into
Conversation
|
|
jonamireh
force-pushed
the
feature/request
branch
from
ad13e63 to
7a8ec04
Compare
adecker89
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
DbxRequestto the public API and adds an optional parameter to the Java Stone backend on using it to generate additional methods that wrap the synchronous methods. This allows callers to capture the API request as an objectDbxRequestis functionally identical tojava.util.Callable; we intend on using as a namespace for Kotlin extensions but don't want to polluteCallablewith those extensions so we're introducing a new type.Newly generated methods with be suffixed with
*Requestand apply to all method types (RPC, download & upload) where they return the result (if any) or theDbxDownloader/DbxUploaderclass. For now, no changes toDbxDownloader/DbxUploader.Test Plan
New tests pass